Improved lib detection: check for matching name in library.properties #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1276) * Improved lib detection: check for matching name in library.properties The library may be stored in a directory that doesn't match the library name, for example we had a case in the wild where the directories: libraries/onewire_2_3_4/... libraries/onewireng_1_2_3/... were used instead of: libraries/OneWire/... libraries/OneWireNg/... this lead to incorrect selection of onewireng_1_2_3 when using OneWire.h (because the OneWireNg had an architecture=avr that had priority over the architecture=* of onewire_2_3_4). This commit will restore priority straight. * Added test for lib resolve improvement * Lib discovery: always prefer libraries with the correct directory name * [skip changelog] Add integration test Co-authored-by: Silvano Cerza <[email protected]>
silvanocerza
force-pushed
the
scerza/improve-lib-detection
branch
from
a09ff64 to
888a9a3
Compare
per1234
approved these changes
May 26, 2021
This was referenced May 28, 2021
This was referenced Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)This PR reintroduces the changes reverted by #1290.
Compiling a Sketch that includes
OneWire.hfor an Arduino Uno while bothOneWireNgandOneWirelibraries are installed incorrectly compiles using theOneWireNglibrary.The name set in the
library.propertiesis now also used to understand which library to use for compilation of a Sketch.This improves library resolution in case multiple libraries have the same header include name but a different library name.
For example compiling a Sketch that includes
OneWire.hfor an Arduino Uno while bothOneWireNgandOneWirelibraries are installed will now resolve toOneWireand compile correctly.titled accordingly?
No.
test_compile_with_esp32_bundled_librariesandtest_compile_with_esp8266_bundled_librarieshave been modified to verify that compilation for those cores fails as expected, they will be reverted to verify compilation works correctly after the libraries bundled with those cores are fixed as defined in #1292.See how to contribute